Bug #170
sidebars broken in trunk (1039)
| Status : | Closed | Start : | ||
| Priority : | High | Due date : | ||
| Assigned to : | tobi - | % Done : | 0% |
|
| Category : | frontend | |||
| Target version : | - | |||
| Resolution : | fixed |
Description
Upgraded to latest trunk after a long absence. DB migration ran fine. Sidebars are now broken. None of the previous sidebars appear. Reading other tickets re: sidebars told me to clear the sidebars table, did that.
The issue -
I add any sidebar in admin/sidebar. the log shows -
Processing SidebarController#index (for 192.168.1.103 at 2006-05-06 13:38:31) [GET]
Session ID: c17b530b3868d61133d94258aace379b
Parameters: {"action"=>"index", "controller"=>"admin/sidebar"}
Rendering within layouts/administration
Rendering admin/sidebar/index
Completed in 0.02665 (37 reqs/sec) | Rendering: 0.01927 (72%) | DB: 0.00368 (13%) | 200 OK Processing SidebarController#set_active (for 192.168.1.103 at 2006-05-06 13:38:35) [POST]
Session ID: c17b530b3868d61133d94258aace379b
Parameters: {"action"=>"set_active", "controller"=>"admin/sidebar", "active"=>archives" "instructions}
Rendering admin/sidebar/set_active
Start rendering component ({:action=>"configure_wrapper", :layout=>false, :controller=>Plugins::Sidebars::ArchivesController}):
Processing ArchivesController#configure_wrapper (for 192.168.1.103 at 2006-05-06 13:38:35)
Completed in 0.00332 (301 reqs/sec) | Rendering: 0.00213 (64%) | DB: 0.00028 (8%) | 200 OK "End of component rendering
Completed in 0.20454 (4 reqs/sec) | Rendering: 0.12440 (60%) | DB: 0.00480 (2%) | 200 OK [http://192.168.1.10/admin/sidebar/set_active":http://192.168.1.10/admin/sidebar/set_active]
looks fine to me. But when I click on Pubish Changes. This error shows up in the log
Processing SidebarController#publish (for 192.168.1.103 at 2006-05-06 13:38:37) [POST]
Session ID: c17b530b3868d61133d94258aace379b
Parameters: {"action"=>"publish", "controller"=>"admin/sidebar"}
TypeError (can't convert String into Integer):
/app/controllers/admin/sidebar_controller.rb:56:in @[]'
/app/controllers/admin/sidebar_controller.rb:56:in @publish'
/app/controllers/admin/sidebar_controller.rb:55:in @publish'
/vendor/rails/activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb:51:in @transaction'
/vendor/rails/activerecord/lib/active_record/transactions.rb:91:in @transaction'
/app/controllers/admin/sidebar_controller.rb:51:in @publish'
/vendor/rails/actionpack/lib/action_controller/base.rb:910:in @perform_action_without_filters'
/vendor/rails/actionpack/lib/action_controller/filters.rb:368:in @perform_action_without_benchmark'
/vendor/rails/actionpack/lib/action_controller/benchmarking.rb:69:in @perform_action_without_rescue'
/usr/lib64/ruby/1.8/benchmark.rb:293:in @measure'
/vendor/rails/actionpack/lib/action_controller/benchmarking.rb:69:in @perform_action_without_rescue'
/vendor/rails/actionpack/lib/action_controller/rescue.rb:82:in @perform_action'
/vendor/rails/actionpack/lib/action_controller/base.rb:381:in @process_without_filters'
/vendor/rails/actionpack/lib/action_controller/filters.rb:377:in @process_without_session_management_support'
/vendor/rails/actionpack/lib/action_controller/session_management.rb:117:in @process'
/vendor/rails/railties/lib/dispatcher.rb:38:in @dispatch'
/vendor/rails/railties/lib/fcgi_handler.rb:150:in @process_request'
/vendor/rails/railties/lib/fcgi_handler.rb:54:in @process!'
/usr/lib64/ruby/gems/1.8/gems/fcgi-0.8.6.1/./fcgi.rb:600:in @each_cgi'
/usr/lib64/ruby/gems/1.8/gems/fcgi-0.8.6.1/./fcgi.rb:597:in @each_cgi'
/vendor/rails/railties/lib/fcgi_handler.rb:53:in @process!'
/vendor/rails/railties/lib/fcgi_handler.rb:23:in @process!'
/var/usrwww/typo/rails/public/dispatch.fcgi:25
Associated revisions
Closes #170. Usability/U.I. tweaks and general polishing
History
05/07/2006 05:03 AM - elucas-gmail-omc -
Some more details.
After playing some more, I figured out how to get sidebars (some of them anyway) to display...
I had to update the 'active_position' and 'staged_position' columns of the sidebars table to non null. After doing the update I was able to refresh /admin/sidebar and the sidebars I updated are now displayed, i.e. I can edit the configs and re-order the sidebars.
Another issue -
When I try to remove a sidebar (in this case the Amazon sidebar) I get the following error.
NoMethodError (undefined method @reject' for nil:NilClass):
/app/controllers/admin/sidebar_controller.rb:44:in @remove'
/vendor/rails/actionpack/lib/action_controller/base.rb:910:in @perform_action_without_filters'
/vendor/rails/actionpack/lib/action_controller/filters.rb:368:in @perform_action_without_benchmark'
/vendor/rails/actionpack/lib/action_controller/benchmarking.rb:69:in @perform_action_without_rescue'
/usr/lib64/ruby/1.8/benchmark.rb:293:in @measure'
/vendor/rails/actionpack/lib/action_controller/benchmarking.rb:69:in @perform_action_without_rescue'
/vendor/rails/actionpack/lib/action_controller/rescue.rb:82:in @perform_action'
/vendor/rails/actionpack/lib/action_controller/base.rb:381:in @process_without_filters'
/vendor/rails/actionpack/lib/action_controller/filters.rb:377:in @process_without_session_management_support'
/vendor/rails/actionpack/lib/action_controller/session_management.rb:117:in @process'
/vendor/rails/railties/lib/dispatcher.rb:38:in @dispatch'
/vendor/rails/railties/lib/fcgi_handler.rb:150:in @process_request'
/vendor/rails/railties/lib/fcgi_handler.rb:54:in @process!'
/usr/lib64/ruby/gems/1.8/gems/fcgi-0.8.6.1/./fcgi.rb:600:in @each_cgi'
/usr/lib64/ruby/gems/1.8/gems/fcgi-0.8.6.1/./fcgi.rb:597:in @each_cgi'
/vendor/rails/railties/lib/fcgi_handler.rb:53:in @process!'
/vendor/rails/railties/lib/fcgi_handler.rb:23:in @process!'
/var/usrwww/typo/rails/public/dispatch.fcgi:25
BTW, if it makes a difference I'm using mysql.
Thanks,
Eric