Bug #192

Memory leak in ContentController#preview

Added by erolms-googlemail-com - 687 days ago. Updated 6 days ago.

Status :Closed Start :
Priority :High Due date :
Assigned to :neuro - % Done :

0%

Category :admin
Target version :5.0.4
Resolution :

fixed


Description

Experiencing a memory leak in preview method of ContentController while writing an article in admin interface. This seems alike #972 and #1088. After disabling loads of stuff (see http://www.stevelongdo.com/articles/2006/08/04/typo-4-0-and-memory-reduction - sidebar modules, sparkline textfilter, etc.) the leak appears to be reduced and it does not knock out the webserver that quickly.
Is there a quick and dirty way to disable caching for preview method to test if memory leak still presist?

History

09/05/2006 10:29 AM - erolms-googlemail-com -

Still no luck there, Typo is leaking memory on every backend/admin corner. Admin preview is the winner - knocks out the webserver in just a few minutes. Noticed that feed funtions produce the same result.

Forgot to mention that I run Typo directly from lighttpd as fcgi server.

09/08/2006 08:40 AM - erolms-googlemail-com -

Just uploaded an output of the MemoryProfiler including one of the String dumps. Cannot really interpret the log and how to relate it to the code (finding memory leak). Help! :-)

09/08/2006 07:12 PM - steve-longdo-gmail-com -

I was noticing a lot of repeated Strings with your Articles content. I am not a lawyer, but I think the preview method in content_controller needs to be tweaked.

 def preview
    @headersContent-Type = "text/html; charset=utf-8" 
    @article = Article.new(params[:article])
    render :layout => false
 end
Article.*new*? Really? :-P

Also there are some strings pulled in for the load path that can and should probably be excluded in config/environments/production.rb for bin/doc/log/public/script/test or alternatively environments.rb should include only the paths it actually should app/lib/vendor. I'll investigate this tonight. I haven't submitted a Typo patch lately.

07/13/2008 02:29 PM - neuro -

  • Status changed from New to Closed
  • Assigned to changed from scott - to neuro -
  • Target version set to 5.0.4
  • Resolution set to fixed

The live preview has been removed in this version.

Also available in: Atom PDF