Bug #231

Changeset 171 breaks comments on articles

Added by wismar-gmail-com - 1178 days ago. Updated 1178 days ago.

Status :Closed Start :
Priority :Normal Due date :
Assigned to :tobi - % Done :

0%
Category :admin
Target version :-
Resolution :

invalid

Description

Changeset r171 to fix ticket #42 breaks the comment#transform_body method, which expects the old behavior of a default value for the second text_filter argument in HTMLEngine#transform

With the change applied, adding a comment results in the following error, instead of a comment:

ArgumentError in  Articles#comment

wrong number of arguments (1 for 2)

/app/models/comment.rb:26:in @transform'
/app/models/comment.rb:26:in @transform_body'
app/controllers/articles_controller.rb:102:in @comment'

A default value of text_filter="" could solve this in HTMLEngine#transform, and maintain the respect for the 'none' text_filter, or some method of choosing/allowing a default comment transform filter could be added to the comment model

Associated revisions

Revision 498
Added by Caged 1066 days ago

Closes #231 U.I. changes and cleanup up redundant screens.

History

04/14/2005 11:07 PM - wismar-gmail-com -

  • Status changed from New to Closed
  • Resolution set to invalid

Actually, it doesn't if you use the right copy of html_engine.rb, that does already have a default value. Oops.

Also available in: Atom PDF